Problem/Motivation

\Drupal\Core\Config\DatabaseStorage::decode says that it throws an \ErrorException, but it does not, because it is suppressed. The funny part is the @throws annotation was added in the same commit that we suppressed the error.

Steps to reproduce

Proposed resolution

Swap the whole docblock for inheritdoc.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3550070

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !13397

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward

astonvictor’s picture

astonvictor commented

seems not many changes :)
+1 RTBC

xjm’s picture

xjm
she/her
Primary language English
commented
Title: DatabaseStorage::decode docs are incorrect » DatabaseStorage::decode() docs are incorrect

  • xjm committed 7a962985 on 11.x 
    Issue #3550070 by mstrelan: DatabaseStorage::decode() docs are incorrect

  • xjm committed a89b4e66 on 11.2.x 
    Issue #3550070 by mstrelan: DatabaseStorage::decode() docs are incorrect...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x, and cherry-picked to 11.2.x as a patch-safe docs bugfix. Thanks @mstrelan!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

xjm closed merge request !13397

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.