Problem/Motivation

In #2539634: PathItem::delete() never runs because the path field type is a computed field in disguise we combined the code paths for deleting path aliases when the parent entity or just one of its translations are deleted, but forgot about language-neutral aliases.

Steps to reproduce

- on a site with at least two languages (e.g. English and French)
- create a node in the default site's language (e.g. English) without specifying an alias on the node form
- create a language-neutral alias for that node (from /admin/config/search/path/add)
- delete the node and notice that the path alias was not deleted

Proposed resolution

Fix it.

Remaining tasks

Review.

User interface changes

Nope.

Introduced terminology

N/A

API changes

Nope.

Data model changes

Nope.

Release notes snippet

N/A

Issue fork drupal-3549608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !13364

amateescu’s picture

amateescu commented
Status: Active » Needs review
alecsmrekar’s picture

alecsmrekar commented
Status: Needs review » Reviewed & tested by the community

Looks great and makes sense, thanks!

  • catch committed a1b29b60 on 11.2.x 
    Issue #3549608 by amateescu, plach: Language-neutral path aliases are...

  • catch committed 89b8ce89 on 11.3.x 
    Issue #3549608 by amateescu, plach: Language-neutral path aliases are...

  • catch committed 018bfdae on 11.x 
    Issue #3549608 by amateescu, plach: Language-neutral path aliases are...

catch closed merge request !13364

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x and 11.2.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.