Problem/Motivation

user_form_system_regional_settings_submit does not need exist - we can use #config_target for this.

Proposed resolution

remove user_form_system_regional_settings_submit and define #config_target in the form alter

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

N/a

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3549583

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Category: Task » Bug report
Status: Active » Needs review

This is actually a bug fix because the form alter is using \Drupal::confg() and getting overridden config which is wrong for forms...

alexpott opened merge request !13361

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I can't find anything to give feedback about. It's a pretty straightforward change. Still, I tested the form thoroughly. The system.date configuration continues to update appropriately. Seems RTBC to me.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d471941bbf3 to 11.x and 6763cd1d5c6 to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !13361

  • longwave committed 6763cd1d on 11.3.x 
    fix: #3549583 Use #config_target to remove...

  • longwave committed d471941b on 11.x 
    fix: #3549583 Use #config_target to remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.