Motivation

Make sure slots are supported properly. Have some test-component covered by kernel tests with slots.

Issue fork canvas_extjs-3549493

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago opened merge request !3

fago’s picture

fago
Primary language German
Location Vienna
commented
Version: » 1.x-dev
Status: Active » Needs review

I had to implement slot support in the component-preview helper module of Nuxt first. I made sure it works with nested components also:
https://github.com/drunomics/nuxt-component-preview/releases/tag/1.0.0-a...

Given that, I got it working, even with nested slots. It works with latest custom elements 3.x and https://github.com/drunomics/nuxt-component-preview/releases/tag/1.0.0-a... or later.

However, during testing I found one issue. The canvas overlay for interacting with components is not calculating the right position when having JS-rendered layouts, it seems to be fail to find the right position. As workaround elements can be dragged and selected from the left-array sidebar meanwhile. This is probably something we need to look into with canvas folks.

  • fago committed 672f0b8b on 1.x 
    [#3549493] feat: Add support for using slots.

By: fago
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.