Problem/Motivation

Drupal Core has a new API for form validation using #config_target, see https://www.drupal.org/node/3373502

Proposed resolution

Update configuration form to use #config_target

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

Issue fork remove_http_headers-3549463

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !4

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request implements the following changes:

  1. The configuration is now saved through the #config target property, see https://www.drupal.org/node/3373502
  2. Validation is now done through config schema instead of form validation
  3. Cache invalidation is now done through a config listener instead of form submit
dennisdk’s picture

dennisdk
Primary language Dutch
commented

Works as expected!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@dennisdk officially RTBC'd?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@idebr would you maybe also review #3425737: Configuration overrides are not applied due to use of editable configuration for getting headers?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Is ^10.3 fine as minimum Drupal version for this?

Then I'd merge this!

idebr’s picture

idebr commented

#config_target is available from Drupal 10.2.0, see https://www.drupal.org/node/3373502

  • anybody committed 58b24e0e on 2.x authored by idebr 
    Issue #3549463: Use #config_target for the settings form
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thank you @idebr! Merged!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.