Problem/Motivation

The configuration form for breakpoint templates includes grid settings, and the Swiper API supports these settings for breakpoints, but Swiper Formatter ignores grid settings when preparing breakpoints for the swiper config.

Steps to reproduce

Create a breakpoint template with different grid settings than the base template. Those settings will not be included in the config array output on the page.

Proposed resolution

Add 'grid' to the list of included settings in the Swiper::prepareBreakpoints() function.

Remaining tasks

Patch module.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork swiper_formatter-3549240

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jstoller created an issue. See original summary.

jstoller opened merge request !27

jstoller’s picture

jstoller
he/him
commented
Status: Active » Needs review
bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented

Hi @jstoller,

Thanks for reporting the issue and providing a fix.
It looks good to me, I'll test when I get the chance.

  • bbu23 committed d72b2268 on 2.1.x authored by jstoller 
    fix: #3549240 Include grid settings in breakpoint config

By: jstoller
bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented
Status: Needs review » Fixed

Will be available in 2.1.0

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.