Problem/Motivation

Similar to #3447617: Stop automatic storage creation of body field for node we should stop shipping storage.body with block_cotent

Steps to reproduce

NA

Proposed resolution

* Prevent creating the body field storage automatically for block types.
* Add a BC module block_content_storage_body_field
* Fix tests

Remaining tasks

Implement
Review

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3548762

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !13314

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

Thanks @dcam addressed your feedback.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The basic functionality of the change works.

When I install the Standard profile the block_content Body field storage is still automatically created because the config was copied to the profile.

When I install the Minimal profile the Body field storage is not automatically created. I can install the block_content_storage_body_field module to get the field storage.

I fixed a typo and a copy/paste error in the CR.

Tests are passing. My feedback was already addressed. This one looks good to me.

  • catch committed fda64853 on 11.x 
    Issue #3548762 by smustgrave, dcam: Stop automatic storage creation of...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This looks good and indeed very similar to the node one. text_with_summary makes even less sense for blocks, must have been a copy and paste a long time ago. Much less assumes that block body fields exist than nodes so this is pretty low risk (hopefully that's actually the case).

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

catch closed merge request !13314

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.