Problem/Motivation

I've demoed this module to a group of ~10 people and we agreed that the warning message could use some improvement.

How it looks now:
Screenshot of warning messages shown to a user when attempting to edit a locked node. See below for text.

So we have two separate warning messages, one reads:

This content is being edited by the user cm1 and is therefore locked to prevent other users changes. This lock is in place since 3 min 24 sec.

And the other reads:

Click here to Break lock

Proposed resolution

I originally thought we should combine the two messages into one, but when I was testing in Drupal 11 I see that's already happening. Only in Drupal 10 do the two messages appear distinct.

I propose the messages be changed to this:

Screenshot of warning messages shown to a user when attempting to edit a locked node. See below for text.

This content is being edited by the user "cm1" and is therefore locked to prevent changes by other users. This lock has been active for 3 minutes.

and

Break the lock.

I feel this phrasing flows better. It also surrounds the username in quotes which makes it easier to understand its the username. This also removes the seconds granularity from the message, which is likely too verbose (seconds are still used if it's less than 1 minute).

And the "Break the lock." is a bit more elegant than "Click here to Break lock", which was missing a period, had a capital B, and an erroneous "click here" (wasn't part of the link).

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bkosborne created an issue. See original summary.

bkosborne’s picture

Assigned: Unassigned » bkosborne
bkosborne’s picture

Issue summary: View changes
StatusFileSize
new44.59 KB
bkosborne’s picture

Status: Active » Needs review

bkosborne’s picture

Those test failures are unrelated

dan3h’s picture

I came here to create a ticket to suggest rewording the lock-warning message to almost EXACTLY what you proposed. So I am happy to see someone else has already done it. Thanks, @bkosborne!

alexpott made their first commit to this issue’s fork.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

I've changed the username token to use the % placeholder - as this will mark up the username appropriately. The other changes here look great. Thanks!

alexpott’s picture

Category: Feature request » Task

  • alexpott committed 80f28028 on 3.x
    task: #3548506 Improve clarity and make more succinct the lock warning...
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.