Problem/Motivation

Process isolation in PHPUnit 12 must be specified on each concrete test class.

Proposed resolution

In this issue, add #[RunTestsInSeparateProcesses] attribute to all Kernel tests.

1587 classes affected.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3548493

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

mondrake opened merge request !13444

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

Good grief, what a pain! I kind of can't believe such a breaking decision was made upstream by PHPUnit.

I read through the entire nearly 30,000 line patch. It's just the same two changes over and over and over... The only strange things about it were the three instances of alphabetized unrelated use statements.

I was going to say "Let's get this in before it gets stale," but it already is and needs a rebase.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Avoid commit conflicts

@dcam thanks for the review effort... really remarkable.

The reason why you see seemingly unrelated rearranging of use imports is due to the fact that the refactoring is done by rector, whereas the resorting is done by phpcbf on any file changed, independently from what the change was.

Will rebase now - tagged 'Avoid commit conflicts' exactly for the reason in #6.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

rebased

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Looks good. Let's do it.

  • catch committed 03917c0a on 11.x 
    Issue #3548493 by mondrake, dcam: Add #[RunTestsInSeparateProcesses]...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

catch closed merge request !13444

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.