The "Discard changes" form currently has an "Include dependencies" checkbox. When checked, the changes made to the dependent entities are also discarded. It would be good to list the dependencies down and allow the user to select if they were to keep changes to certain dependencies.
Add list of dependent entities and allow the user to "unselect" any discard option for a dependency.
The Drupal\wse\WseWorkspaceAssociation::gatherAffectedDependencies needs to be made public with some changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3548237-without-ajax.diff | 25.99 KB | ajits |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
ajitsCreated a MR.
Comment #4
ajitsLooking at the test failures.
Comment #5
ajitsIt looks like other MRs had the same failures. So, this seems unrelated to the issue.
Comment #6
ajitsAll raised issues were addressed. This is ready for another review. Thanks!
Comment #7
alecsmrekar commentedLooks great!
Comment #8
ajitsComment #10
ajits@amateescu - The changes you've made work great! I should have mentioned that I tried going through the AJAX route too. However, it took a lot of time for the dependencies to load me on the project I was working on. So, I decided to opt for getting the dependencies on form load. Seemed better for the UX. I will try to get some numbers.
Comment #11
ajitsI did some profiling and found that the time taken to load the dependencies with and without AJAX is about the same.
There are other function calls without AJAX pushing up the total time. So, not a huge difference in terms of performance gain. However, the difference will happen when the user clicks the "Include dependencies" checkbox, unchecks it, and then checks it again. This will cause the AJAX to fire again and take about the same time to gather and list the dependencies.
I am also adding the patch I used it is from the commits I've made and the merge from 2.0.x branch.
P.S - I did not attach detailed report of profiling as there were no notable difference.
Comment #12
ajitsComment #15
amateescu commentedMerged into 3.0.x and cherry-picked to 2.0.x, thanks!