Problem/Motivation

UserRestrictions::getOriginalId() uses the following code.

public function getOriginalId(): string {
  return $this->originalId;
}

That is the same code used by ConfigEntityBase, the parent class.

Proposed resolution

Remove UserRestrictions::getOriginalId().

Issue fork user_restrictions-3548066

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

tanushree gupta’s picture

tanushree gupta commented
Assigned: Unassigned » tanushree gupta
tanushree gupta’s picture

tanushree gupta commented

Working on it!!

tanushree gupta changed the visibility of the branch 3548066-remove-userrestrictionsgetoriginalid to hidden.

tanushree gupta opened merge request !24

tanushree gupta’s picture

tanushree gupta commented
Assigned: tanushree gupta » Unassigned
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

This issue is for the 3.0.x branch, while the merge request has been created for the 2.0.x branch.
While the change would eventually be back-ported, it needs to be first provided for the 3.0.x branch.

tanushree gupta opened merge request !26

tanushree gupta changed the visibility of the branch 3548066-remove-getOriginalId() to hidden.

tanushree gupta changed the visibility of the branch 3548066-RemoveUserRestrictions to hidden.

tanushree gupta’s picture

tanushree gupta commented
Status: Needs work » Needs review

MR 26 is against branch 3.0.x
Please review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
tanushree gupta’s picture

tanushree gupta commented
Status: Needs work » Needs review

Remove lines according to comment.
Please review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 3.0.x-dev » 2.0.x-dev

avpaderno changed the visibility of the branch 3548066-remove-getOriginalId() to active.

avpaderno changed the visibility of the branch 3548066-remove-getOriginalId() to hidden.

avpaderno opened merge request !28

  • avpaderno committed 00c4fe49 on 2.0.x 
    Issue #3548066: Remove UserRestrictions::getOriginalId()
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

avpaderno closed merge request !24

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.