Problem/Motivation

The css/theme/media-library.css file contains the following lines.

/**
 * @todo Reuse or build on vertical tabs styling for the media library menu.
 *   https://www.drupal.org/project/drupal/issues/3023767
 */

#3023767: Reuse or build on vertical tabs styling in media library has been closed as won't fix for the following reason.

Although we did have to copy the styles for Media Library, we can't really reuse the ones from vertical tabs, or refactor them to be compatible. The vertical tab styles in core where not really meant to work with any ol' list of links, and it'd be a lot of effort, for very little reward, to change that.

Proposed resolution

Remove the full comment.

Issue fork seven-3547057

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

avpaderno created an issue. See original summary.

sourabhsisodia_’s picture

Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_’s picture

Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
avpaderno’s picture

Status: Needs review » Reviewed & tested by the community
avpaderno’s picture

Version: 2.0.x-dev » 1.0.x-dev
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport

I will back port the change to the 1.0.x branch.

avpaderno’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Reviewed & tested by the community

  • avpaderno committed 0d1603ea on 1.0.x
    Issue #3547057: Remove the first @todo note in the css/theme/media-...
avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.