Problem/Motivation

Locally there is no problem but on production with a more limited CPU and memory I'm seeing some larger (23mb JPEG) images not get processed and hit the thrown error "Image generation in progress. Try again shortly."

Steps to reproduce

I don't have exact repro steps, I guess it might be possible to set up a very limited container in terms of CPU and memory and test it there.

Proposed resolution

A better locking system that has a progressive backoff and retries. So if the generation doesn't complete in 3 seconds it tries again with a 4.5 second buffer then 6.75s, then 10s and finally 15s. This should allow adequate time for the generation of a large image to complete.

This is my hope anyway and as I can't easily replicate locally I'm going to have to use this issue as a testing ground to see if I can fix it on the staging/prod environment.

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3546893-generation-timeout-too Comparecompare
  • 1.0.x Comparecompare

Comments

tanc created an issue. See original summary.

tanc’s picture

I just realised the image generation and locking is all core stuff so not easily changeable. I'll hit pause for a minute and do some more debugging

tanc’s picture

Status: Active » Closed (works as designed)

Closing in favour of #3552016

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.