Problem/Motivation

The css/theme/media-library.css file contains the following lines.

/*
 * @todo Remove.
 *   @see https://www.drupal.org/project/drupal/issues/3064914
 */
.views-live-preview .media-library-view div.views-row + div.views-row {
  margin-top: 0;
}

The linked issue (#3064914: Views preview adds margin top to views rows) has been closed as duplicate of #2272533: Excessive margin-top in Views live preview, which was closed as Closed (works as designed).
It means those CSS properties no longer need to be removed.

Proposed resolution

Remove the @todo note.

Issue fork seven-3546837

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
anirudhsingh19’s picture

anirudhsingh19 commented
Assigned: Unassigned » anirudhsingh19

working on it

anirudhsingh19 opened merge request !203

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: anirudhsingh19 » Unassigned
Status: Needs review » Reviewed & tested by the community

Thank you for the patch! The change is indeed correct.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.0.x-dev » 1.0.x-dev
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport

I will make the same change for the 1.0.x branch.

avpaderno opened merge request !205

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
Issue tags: -Needs backport

  • avpaderno committed 150b2de1 on 1.0.x 
    Issue #3546837: Remove the @todo note on the bottom of the css/theme/...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: avpaderno » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.