Problem/Motivation

The css/components/buttons.css file contains the following lines.

/**
 * Buttons.
 *
 * 1. Enable z-index on buttons.
 * 2. Normalize 'line-height'; can’t be changed from 'normal' in Firefox 4+.
 * 3. Allow full range of styling in Webkit and Gecko.
 * 4. Use pixel units to ensure button text is centered vertically.
 * 5. Use rems to avoid the font size cascade of ems, with a pixel fallback for
 *    older browsers.
 * 6. Prevent fat text in WebKit.
 *
 * @todo Consider moving box-sizing into base.css under a universal selector.
 *   See https://www.drupal.org/node/2124251
 */

The linked issue (#2124251: Apply 'box-sizing: border-box' globally.) has been stale for 12 years and it is probably going to be closed.

Proposed resolution

Remove that @todo note from the css/components/buttons.css file.

Issue fork seven-3546832

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

avpaderno created an issue. See original summary.

tanushree gupta’s picture

Assigned: Unassigned » tanushree gupta

tanushree gupta’s picture

Assigned: tanushree gupta » Unassigned
Status: Active » Needs review

avpaderno’s picture

Version: 2.0.x-dev » 1.0.x-dev

  • avpaderno committed 673652e5 on 1.0.x
    Issue #3546832:  Remove the @todo note in css/components/buttons.css
    
avpaderno’s picture

Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.