Problem/Motivation

All the reminders are.being stored as Config, we don't want this to move as environments are changed

Proposed resolution

Refactor code to use ContentEntity rather than ConfigEntity while maintaining backwards capability.

Issue fork content_reminders-3546723

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

theloneliestmonk created an issue. See original summary.

theloneliestmonk opened merge request !10

timozura made their first commit to this issue’s fork.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Let's set this to needs review

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: theloneliestmonk » Unassigned
Status: Active » Needs review

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 1.0.x-dev » 2.0.x-dev
Status: Needs review » Fixed

https://www.drupal.org/project/content_reminders/releases/2.0.x-dev

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

theloneliestmonk opened merge request !11

theloneliestmonk closed merge request !10

timozura’s picture

timozura commented
Status: Fixed » Reviewed & tested by the community

Tested by installing the 1.0.0 version and creating some reminders using config for storage.
Then I checked out this MR and ran updb. The reminders were converted to content reminder entities and stored in the database.
Was able to create new reminders and received e-mail in mailpit.

timozura’s picture

timozura commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.