Problem/Motivation

Currently the need to support D9 prevents us from using newer features such as object oriented hooks. It also requires us to stay PHP 7.4 compatible, which precludes us from using D8 features such as attributes.

Before making this change, I would like to confirm that there is no compelling case for keeping 9.x support. If you are still using Drupal 9, please comment below.

I believe dropping support for unsupported versions of Drupal does not require a change of major version.

Steps to reproduce

N/A

Proposed resolution

  • Wait for confirmation that D9 support can be dropped.
  • Drop ^9.5 from core_version_requirement in .info.yml file.
  • Increase PHP requirement in composer.json from `">=7.4"` to `">=8.1"`.

Remaining tasks

Currently waiting for any objections to removing support for D9.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork scheduled_publish-3546610

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark’s picture

lostcarpark commented
Version: 4.0.x-dev » 4.2.x-dev

Scheduled Publish 4.1.0 has been released, and should work with Drupal 9, though it hasn't been explicitly tested against it. If there are any security or bugfixes against the 4.1 branch, they will continue to support D9.

However, new features will be developed against the 4.2 branch. In particular, #3546607: Convert procedural hooks to object oriented hooks is in progress to convert to object oriented hooks. As this feature requires autowired services, it is not possible to implement keeping support for Drupal 9. Therefore, this change is to remove D9 support from the 4.2 branch.

lostcarpark’s picture

lostcarpark commented
Title: Can we drop D9 support from the 4.x branch? » Drop D9 support from the 4.2.x branch?

Edit title to remove question

lostcarpark opened merge request !46

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

Confirmed all tests are passing.

Moving to Needs Review.

vitaliyb98’s picture

vitaliyb98 commented

Hi @lostcarpark, could you please provide some instructions for testing, which will help people to test it?

lostcarpark’s picture

lostcarpark commented

Hi @vitaliyb98,
I don't think there's any explicit testing required.
Certainly no need to test it won't install against Drupal 9, since all that would test is the Drupal 9 module installer.
In my opinion, since the changes are not to any program code, it is sufficient to eyeball the change, confirm it makes sense, and verify the tests are passing in the pipelines.

lostcarpark’s picture

lostcarpark commented

I think someone verifying they can still install the module with this change in D10 or D11 should be sufficient, since all it is doing is removing D9 compatibility.

lostcarpark’s picture

lostcarpark commented

Rebased after merge of #3558356: Dispatch event when an entity is changing state on schedule. Also removed 9.x from test module.

lostcarpark’s picture

lostcarpark commented

As there have been no objections, and the current versions are still available for D9, I'm moving this to RTBC.

lostcarpark’s picture

lostcarpark commented
Status: Needs review » Reviewed & tested by the community

  • lostcarpark committed be741fda on 4.2.x 
    feat: #3546610 Drop D9 support from the 4.2.x branch?

By: lostcarpark
lostcarpark’s picture

lostcarpark commented
Status: Reviewed & tested by the community » Fixed

Merged and verified tests passed. Moving to fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.