Just out of curiosity, any thoughts on removing the module's dependencies on jQuery? I know it's just an admin-side dependency, but it'd be nice to not need it!

CommentFileSizeAuthor
#8 3546338 after, updates.png371.16 KBcsakiistvan
#8 3546338 after, uninstall.png434.73 KBcsakiistvan
#8 3546338 after, permissions.png267.81 KBcsakiistvan
#8 3546338 after, filter.png354.04 KBcsakiistvan

Issue fork module_filter-3546338

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jennypanighetti created an issue. See original summary.

sluc23’s picture

sluc23 commented

+1

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !62

smustgrave’s picture

smustgrave commented
Title: Removing jQuery dependency? » Completely redo the module filter module

Sorry unfortunately got like 80+ modules and this one just doesn't get the attention. So I'm disclosing I ran it through an LMM reviewing the changes along the way. This would be a new 6.0.x branch but just testing for now. Notable changes

1. Removed all uses with jQuery and replaced with vanilla JavaScript
2. Dropped .module legacy hooks and turned fully to OOP and services
3. Limting to 11.4/12
4. Using a template for the tabs to avoid layout shifts.

smustgrave’s picture

smustgrave commented
Version: 5.0.4 » 6.0.x-dev
Status: Active » Needs review

Think ready for eyes.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: Unassigned » csakiistvan
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
StatusFileSize
new 3546338 after, filter.png354.04 KB
new 3546338 after, permissions.png267.81 KB
new 3546338 after, uninstall.png434.73 KB
new 3546338 after, updates.png371.16 KB

@smustgrave Reviewed the rewrite as requested in #6, no issues found.

✅ Tested and works — checked out MR !62 and rebuilt caches, then uninstalled jquery_ui, jquery_ui_menu and jquery_ui_autocomplete: Module Filter stayed enabled and the filter works on /admin/modules, /admin/modules/uninstall, /admin/people/permissions and /admin/reports/updates, with no console errors and no tab layout shift. So the jQuery removal holds and the OOP/template rewrite keeps functional parity.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
Status: Needs review » Reviewed & tested by the community
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.