Problem/Motivation

I've noticed that on some pages, the button usually related to the fields with Ajax is not hidden as it should be.

Steps to reproduce

  1. With the standard installation profile (Drupal 11), visit /admin/structure/types/manage/article/fields page
  2. Click the Edit button for a field like Body
  3. In fieldset Field Storage, you may notice the Update settings button, which does nothing on click

Screenshot

Proposed resolution

We may update the selector .button:not(.button--danger) to .button:not(.button--danger, js-hide) in css/components/buttons.css.

Issue fork seven-3546279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

chewie created an issue. See original summary.

chewie’s picture

Issue summary: View changes
avpaderno’s picture

Issue summary: View changes
StatusFileSize
new22.96 KB

I can confirm the issue.

It does not happen with the Claro theme. We should probably use the same CSS styles / template file it uses.

screenshot

avpaderno’s picture

Truly, with the Claro theme, the Update settings button never appears. I tried changing the settings on that dialog box, but I have not seen that button appear.

chewie’s picture

StatusFileSize
new51.35 KB

It is how it looks with changes in MR:
FF last
The button is hidden. Ajax works as expected.

chewie’s picture

Status: Active » Needs review
chewie’s picture

Yes, the Ajax-related button is hidden on the frontend by .js-hide, but .button:not(.button--danger) overrides that. So we can add additional exclusion to fix that.

avpaderno’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new23.84 KB

I can confirm it works on the live preview.

screenshot

  • avpaderno committed e7895691 on 2.0.x authored by chewie
    Issue #3546279: Button is not hidden with 'js-hide' class
    
avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for another issue and another merge request!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.