Problem/Motivation

GitlabCI now has the ability to run the Drupal "Upgrade Status" module and check for any issues preventing compatibility with the next major release of Drupal.

Steps to reproduce

N/A

Proposed resolution

  • Add RUN_JOB_UPGRADE_STATUS: '1' to the variables section of .gitlab-ci.yml.
  • In order to allow upgrade status to complete cleanly, the smart_trim.info.yml needs to include "^12" in core_version_requirement.

Remaining tasks

Create merge request with above changes.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork smart_trim-3545564

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark’s picture

lostcarpark commented
Issue summary: View changes

h_kac made their first commit to this issue’s fork.

h_kac’s picture

h_kac commented
Status: Active » Needs review

I’ve made the change, but I’m not sure how to test it to ensure nothing is broken.

h_kac opened merge request !117

lostcarpark’s picture

lostcarpark commented
Status: Needs review » Needs work

This looks almost perfect.

Upgrade Status is giving a warning about core_version_requirement in the test theme. I know that line can be omitted in test modules, so I suspect it could be removed from the test theme too. I would try deleting the line and see if the tests pass.

h_kac’s picture

h_kac commented
Status: Needs work » Needs review

when I removed it, the pipline failed with a warning "Add core_version_requirement to designate which Drupal versions is the extension compatible with" and also errors related to PHPUNIT
But, when I added ^12 to test theme, the pipeline succeeded

lostcarpark’s picture

lostcarpark commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks.

Looking at it now, I'm not sure why the test modules aren't failing with the same error.

Confirm pipeline is now passing, and new "Upgrade status" task is reporting no issues.

Moving to RTBC.

ultimike made their first commit to this issue’s fork.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks, @lostcarpark and @h_kac!

Merged.

-mike

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • ultimike committed 77ee6b79 on 2.x authored by h_kac 
    task: #3545564 Add upgrade status check to GitlabCI

By: lostcarpark
By...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.