Problem/Motivation

Updating ui_skins 1.1.0-alpha3 => 1.1.0-alpha4 throws error:

ParseError: syntax error, unexpected identifier "HEXADECIMAL_CHANNEL_LENGTH", expecting "=" in Composer\Autoload\includeFile() (line 31 of /web/modules/contrib/ui_skins/src/Element/AlphaColor.php

Steps to reproduce

Upgrade ui_skins 1.1.0-alpha3 => 1.1.0-alpha4: composer update

Then, attempt db update: vendor/bin/drush updb

Proposed resolution

Unsure, haven't finished reviewing the latest commit yet.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ui_skins-3545021

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paskainos created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Category: Bug report » Support request
Priority: Major » Normal

Which PHP version are you using?

Starting 1.1.0-alpha4, ui_skins requires PHP 8.3, but it seems that updating the .info.yml did not put the requirement into the automatically generated composer.json by drupal.org facade.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: ParseError: syntax error, unexpected identifier "HEXADECIMAL_CHANNEL_LENGTH", line 31 of AlphaColor.php » Add composer.json
Version: 1.1.0-alpha4 » 1.1.x-dev
Assigned: Unassigned » grimreaper
Category: Support request » Bug report

After discussion on infrastructure Slack channel, PHP requirement from .info.yml is not extracted, need to create a composer.json file.

Then indicate in previous release the problem.

paskainos’s picture

paskainos commented

Thank you, @grimreaper for your speedy response.

The site in question is running PHP 8.2 - mystery solved! Should've / could've anticipated that. My apologies for not including that crucial bit in (let alone testing for it prior to) my initial post.

After discussion on infrastructure Slack channel, PHP requirement from .info.yml is not extracted, need to create a composer.json file.

Then indicate in previous release the problem.

I'm not quite sure what that means. I guess my question is; do you need me to do anything further at this point?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello @paskainos,

No worries, I will finish this.

Should've / could've anticipated that.

1: I should have (and will) update release note to mention this new requirement
2: I didn't know that this .info.yml requirement was not taken automatically so I will also fix other contrib modules I maintain.
3: the .info.yml change only prevents installation, so for websites with the module already enabled it is not handled

So unfortunately, very little stuff you could have done no worries. Except looking at the whole diff but that's not something normally asked when doing updates ^^.

So it will be ok for next releases, composer will prevent the update, but not for 1.1.0-alpha4 so I will put a big warning message on release note.

grimreaper opened merge request !26

  • grimreaper committed 4bb73e94 on 1.1.x 
    [#3545021] fix: Add composer.json

By: paskainos
By: grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.