Problem/Motivation

Trying out the alpha version of the module and the first problem I notice is one is unable to save changes in the block or field.

Steps to reproduce

1. Install module.
2. Create custom block with custom field.
3. Place block.
4. Edit block and make changes (such as turn on debug mode).
5. Re-edit the block later, the changes are not committed.

No errors appear to be thrown as well. Still testing but thought this was worth a mention.

CommentFileSizeAuthor
#3 countdown-block-save-fix-3545014-2.patch1.89 KBmahyarsbt
#2 countdown-block-save-fix-3545014-1.patch12.75 KBmahyarsbt

Comments

shane birley created an issue. See original summary.

mahyarsbt’s picture

mahyarsbt commented
Version: 2.0.0-alpha2 » 2.0.x-dev
Status: Active » Needs review
Issue tags: +Novice, +Bug report, +Needs testing
StatusFileSize
new countdown-block-save-fix-3545014-1.patch12.75 KB

Thank you @shane-birley for reporting this issue and taking the time to provide clear reproduction steps. Your detailed report made it easy to identify and resolve the problem.

I've investigated the issue and created a patch that addresses the block configuration save problem. The attached patch resolves the issue where countdown block settings were not persisting after saving.

Could you please apply the attached patch and test it in your environment?

Here's how to test:

  1. Apply the patch to the module
  2. Clear your site's cache (drush cr)
  3. Edit an existing countdown block or create a new one
  4. Make some configuration changes
  5. Save the block
  6. Edit the block again to verify your changes were saved

Please let me know if this resolves the issue for you or if you encounter any other problems. Your feedback is valuable to ensure this fix works properly across different use cases.

Thank you again for your contribution to improving the Countdown module!

mahyarsbt’s picture

mahyarsbt commented
StatusFileSize
new countdown-block-save-fix-3545014-2.patch1.89 KB

I've created a cleaner patch that focuses specifically on the block save issue. This minimal patch only modifies the necessary line in CountdownBlock.php to fix the problem.

Applying a patch
Download the patch to your working directory. Apply the patch with the following command:
git apply -v countdown-block-save-fix-3545014-2.patch

This minimal approach ensures we only change what's necessary to resolve the issue. Please test and let me know if it works for you.

  • mahyarsbt committed e4fc213d on 2.0.x 
    Issue #3545014 by shane-birley, mahyarsbt: Fix block configuration not...
mahyarsbt’s picture

mahyarsbt commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Bug report, -Needs testing +Quick fix

I've tested the patch and confirmed it resolves the block save issue. The fix is minimal and only uncomments the essential parent::blockSubmit() call.

mahyarsbt’s picture

mahyarsbt commented

Committed to 2.0.x-dev. Thanks @shane-birley for reporting this issue!

This will be included in the next release.

mahyarsbt’s picture

mahyarsbt commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 2.0.x-dev.

Thanks @shane-birley for reporting this issue!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

shane birley’s picture

shane birley commented

No worries, I am excited about this module's development since I need it for a few projects. Thanks for checking into this!

The older module works great too (and I overlayed the older one with Flipdown to make it fancy). Will test out this patch today.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.