Problem/Motivation

When an instance is created, it is with a profileId property:

  /**
   * Display Builder profile ID.
   */
  protected string $profileId = '';

However, after creation of the instance, this property is never updated, even when the related property is updated by WithDisplayBuilderInterface implementations on config or content.

Proposed resolution

This property as a setter : InstandeInterface::setProfile(), Let's use it.

Issue fork display_builder-3544545

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau
Issue tags: -display_builder-1.0.0-beta +display_builder-1.0.0-beta1

Also, add Profile to Instance list builder

pdureau opened merge request !141

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Active » Needs review

I am still not sure about why we are storing the profile ID also in the Instance entity, but at least the value stays synced with config now.

pdureau’s picture

pdureau commented
Assigned: mogtofu33 » pdureau
Status: Needs review » Needs work

ooops ! Pipeline red

pdureau’s picture

pdureau commented
Title: Profile changed in config or content don't update the instance entity » Profile changed in config don't update the instance entity
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

Green :)

  • mogtofu33 committed 4b9e0fd9 on 1.0.x authored by pdureau 
    [#3544545] fix: Profile changed in config don't update the instance...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.