Problem/Motivation

I see some PHPSTAN issues that are worth to fix (we'll look into fixing the tests later):

https://git.drupalcode.org/project/ckeditor_font/-/pipelines/572155

Steps to reproduce

Look into the results of the pipeline execution:

https://git.drupalcode.org/project/ckeditor_font/-/pipelines/572155

Proposed resolution

Fix the issues.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork ckeditor_font-3544104

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danrod created an issue. See original summary.

vinodhini.e made their first commit to this issue’s fork.

danrod’s picture

danrod
Location Ottawa
commented
Title: Fix PHPSTAN issues in the 8.x-1.x branch » Fix PHPSTAN issues in the 2.0.x branch
Version: 8.x-1.x-dev » 2.0.x-dev

danrod changed the visibility of the branch 3544104-fix-phpstan-issues to hidden.

danrod opened merge request !39

danrod’s picture

danrod
Location Ottawa
commented

I was able to fix the PHPSTAN issue, but still we need to fix the test (Hope to do that later this week), for now I'll set this to "Needs Review".

Hope someone would review this, I'd appreciate it.

Thanks.

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Fixed
Issue tags: +Novice

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.