Problem/Motivation

There is currently no integration with logging.

There are some try/catch blocks in the module where logging would be helpful to log any errors communicating with Vertex.

The code should be reviewed in general, however, to identify any areas that would benefit from watchdog logging.

This functionality would prove useful especially when launching vertex search on a site and wanting to monitor it's success.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

timozura created an issue. See original summary.

timozura’s picture

Title: Add watchdog integration » Add logging for exception handling.
Issue summary: View changes
timozura’s picture

Status: Active » Needs review

This needs testing.

Best way to test is to take an existing Vertex custom search page and modify the path to the credentials file so it breaks and/or modify the datastore id so it is invalid...save the configuration...and then try searching. Look at the recent log messages to see the errors.

samlerner’s picture

Assigned: Unassigned » timozura
Status: Needs review » Reviewed & tested by the community

Tested this and it works well. I'm seeing error messages logged for general errors and API exceptions.

I think this is good to go.

timozura’s picture

Merged in; working on release.

timozura’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.