Problem/Motivation

Replace annotation-based test metadata with PHP attributes.

Proposed resolution

1) Complete the conversion done automatically in #3526490: Convert test annotations to attributes in Drupal/BuildTests, #3533413: Convert test annotations to attributes in modules' BuildTests, #3533453: Convert test annotations to attributes in Drupal/FunctionalJavascriptTests, #3533515: Convert test annotations to attributes in Drupal/FunctionalTests, #3534043: Convert test annotations to attributes in modules' FunctionalJavascript tests and #3534515: Convert test annotations to attributes in modules' Functional tests with the remaining outliers.

2) Set PHPUNIT_FAIL_ON_PHPUNIT_DEPRECATION: true for Build, Functional, FunctionalJavascript test jobs in CI so to 'seal' the testsuites from regressions in using annotation metadata.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3543897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !13116

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Javascript failures were random. Re-running it's all green.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Avoid commit conflicts

  • catch committed e652a8c1 on 11.x 
    Issue #3543897 by mondrake: Complete test annotations to attributes...

catch closed merge request !13116

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.