Problem/Motivation

new deprecations appeared after beta2

Steps to reproduce

- https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_...
- https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_integers...

Proposed resolution

fix them

Remaining tasks

review/commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3543711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost opened merge request !13108

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Did a search for chr( and all instances outside 255 appear to be addressed.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This looks fine, let's get it in so we can get closer to a green test run.

Committed/pushed to 11.x, thanks!

catch closed merge request !13108

  • catch committed bf1d039f on 11.x 
    Issue #3543711 by andypost, smustgrave: Fix PHP 8.5 deprecations of chr...
catch’s picture

catch
he/him
Primary language English
commented
andypost’s picture

andypost
he/him
Primary language Russian
commented

the change looks backportable to 10.6

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.6.x-dev
Status: Fixed » Reviewed & tested by the community

We aren't yet sure if we will have full compatibility for PHP 8.5 in Drupal 10 (our dependencies may not allow it) but I don't see the harm in backporting things like this.

  • catch committed 1d8e338b on 10.6.x 
    Issue #3543711 by andypost, smustgrave: Fix PHP 8.5 deprecations of chr...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Makes sense - cherry-picked to 10.6.x, thanks!

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thank you! surely 10.6 could fail to use PHP 8.5 but this changes are minimal )

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.