Problem/Motivation

PHP 8.4 introduces a deprecation for implicitly nullable parameters: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullabl...

Steps to reproduce

Install module on Drupal 10.5 with PHP 8.4. Log shows deprecation notices such as:

PHP Deprecated: Drupal\flag_search_api\Plugin\search_api\processor\FlagIndexer::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/flag_search_api/src/Plugin/search_api/processor/FlagIndexer.php on line 120

Proposed resolution

Adjust the nullable parameters to declare them as nullable.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

johan.gant created an issue. See original summary.

phily’s picture

Status: Active » Reviewed & tested by the community

MR!12 works for me using Drupal 11.3.3 and flag_search_api 2.0.1