Problem/Motivation

Somehow I only just noticed that the Easy Email Theme appears in the Appearance section, and also in the Block Layout.

Since neither of these actually do anything, can we hide these from the UI? Creating this issue in the module since that's where the change would have to go, I think, but it could check whether the theme is installed and alter the necessary pages if so?

Issue fork easy_email-3543496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

zengenuity’s picture

zengenuity commented

If we hide the theme on the Appearance page, how would you ever remove it if you wanted to? If we use hidden:true in the info file, it's also a problem that you can't enable it if you install it manually. (as opposed to getting it as part of Drupal CMS)

Using hidden:true hides it on both the Appearance page and on the Block Layout page, so I think it's the correct solution. But, we'd have to build an alternative way to install and uninstall it. I suppose we could detect that the theme is available and/or installed and provide an install/uninstall option within Easy Email's UI.

pameeela’s picture

pameeela commented

Using hidden:true hides it on both the Appearance page and on the Block Layout page, so I think it's the correct solution.

Oh, it does too! I thought we looked at that and it didn't totally solve the problem but it certainly does.

To me it makes sense to have the on/off live within the Easy Email module. 'Appearance' is really about your site's appearance, and the fact that your emails are styled by a full-fledged Drupal theme is an odd Drupalism. But I also think the use case of someone who is a UI only user, but also wants to specifically uninstall this theme, is pretty unlikely. But if it can be done without much trouble, that is even better.

zengenuity’s picture

zengenuity commented
Related issues: +#3545277: Hide Easy Email Theme from Appearance and Block layout pages

zengenuity opened merge request !49

zengenuity’s picture

zengenuity commented
Status: Active » Fixed

I've added code to enable and disable Easy Email Theme from the settings area of Easy Email module. And I hid Easy Email Theme in this issue: #3545277: Hide Easy Email Theme from Appearance and Block layout pages

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

pameeela’s picture

pameeela commented

This is excellent, thank you so much!

zengenuity’s picture

zengenuity commented

I've created a new release for this change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.