Problem/Motivation
I just looked into the EntitySubmenuBlock class and thought: Isn't this missing default configuration / schema?
The block introduces settings, but doesn't make use of defaultConfiguration()?
https://www.drupal.org/docs/creating-modules/creating-custom-blocks/add-...
/**
* {@inheritdoc}
*/
public function defaultConfiguration() {
return [
'lorem' => $this->t('ipsum'),
];
}
For the settings introduced, see blockForm()
Guess schema isn't needed then?
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comments
Comment #3
anybody@aleksip: Could you please check and review this? Am I right or am I missing something?
Thanks!
Comment #4
anybodyUpdated on #3542548: Hide the block when there are no results
Comment #5
grevil commentedYes, all fixed in #3479961: Write tests, implement schema, drop D8/9 support, adjust block settings structure.