Problem/Motivation

I just looked into the EntitySubmenuBlock class and thought: Isn't this missing default configuration / schema?

The block introduces settings, but doesn't make use of defaultConfiguration()?
https://www.drupal.org/docs/creating-modules/creating-custom-blocks/add-...

  /**
   * {@inheritdoc}
   */  
  public function defaultConfiguration() {
    return [
      'lorem' => $this->t('ipsum'),
    ];
  }

For the settings introduced, see blockForm()

Guess schema isn't needed then?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

anybody’s picture

Assigned: Unassigned » aleksip
Status: Active » Needs review

@aleksip: Could you please check and review this? Am I right or am I missing something?

Thanks!

anybody’s picture

grevil’s picture

Assigned: aleksip » Unassigned
Status: Needs review » Closed (duplicate)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.