Problem/Motivation

In behavior's attach(), the property of elementSettings variable is assigned one by one. It seems to redundant.

Proposed resolution

Assign all of initial property values at once.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3542159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tom konda created an issue. See original summary.

tom konda opened merge request !13043

tom konda’s picture

tom konda
Primary language Japanese
Location Kanagawa, Japan
commented
Status: Active » Needs work
tom konda’s picture

tom konda
Primary language Japanese
Location Kanagawa, Japan
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Nice little update LGTM!

nod_ made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This has some merge conflicts.

tom konda’s picture

tom konda
Primary language Japanese
Location Kanagawa, Japan
commented
Status: Needs work » Needs review

Fix conflict.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good rebase

nod_ closed merge request !13043

  • nod_ committed 747a536e on 11.x 
    Issue #3542159 by tom konda: The elementSettings property assignment is...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

Committed 747a536 and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.