I'm attempting to upgrade from version 8.x-1.4 to 8.x-1.10 of this module and am running into an issue when trying to reconfigure my podcast view.

I was able to update the module's code via Composer, as well as run database updates:

$ drush updb
 --------- ----------------- ------------- ------------------------------------------------------------------- 
  Module    Update ID         Type          Description                                                        
 --------- ----------------- ------------- ------------------------------------------------------------------- 
  podcast   copyright_field   post-update   Reconfigures views to use select or other on the copyright field.  
 --------- ----------------- ------------- -------------------------------------------------------------------

When I went to my view, and clicked on "Settings" for the "Podcast RSS feed" format, I was hit with a:

Error message
Oops, something went wrong. Check your browser's developer console for more details.

Looking at the console, it showed a huge wall of text (I won't paste the entire thing here - just what I think are the relevant parts...):

AjaxError: 
An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /admin/structure/views/view/main_content_feed/preview/feed_3
StatusText: parsererror
ResponseText: 
Warning:  Undefined array key "value" in /var/www/html/web/modules/contrib/podcast/src/Plugin/views/row/RssFields.php on line 300
Warning:  Undefined array key "value" in /var/www/html/web/modules/contrib/podcast/src/Plugin/views/row/RssFields.php on line 311

(The previous 2 lines were repeated many times.)

Warning:  Undefined array key "podcast:funding_text_field" in /var/www/html/web/modules/contrib/podcast/src/Plugin/views/style/Rss.php on line 481
Warning:  Undefined array key "podcast:payments" in /var/www/html/web/modules/contrib/podcast/src/Plugin/views/style/Rss.php on line 483
Warning:  Trying to access array offset on null in /var/www/html/web/modules/contrib/podcast/src/Plugin/views/style/Rss.php on line 483
Warning:  Undefined array key "attributes" in /var/www/html/web/modules/contrib/podcast/podcast.module on line 74
Warning:  foreach() argument must be of type array|object, null given in /var/www/html/web/modules/contrib/podcast/podcast.module on line 74

(Again, lots of repeating of the previous lines...)

Possibly related to #3443689: Warning: Undefined array key and/or #3497084: PHP Warnings.

-mike

Issue fork podcast-3541710

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ultimike created an issue. See original summary.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Issue summary: View changes

rodrigoaguilera made their first commit to this issue’s fork.

rodrigoaguilera opened merge request !18

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Version: 8.x-1.10 » 8.x-1.x-dev
Status: Active » Needs review

Thanks for reporting. I added checks around the code that is giving warning including the ones from the other issue linked.
Can you try the MR?

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

@rodrigoaguilera - 9 months later and I finally have made this a priority again! I'm pretty sure that most of this issue is PHP 8 related.

Here's what I did:

  1. Updated my local to this issue's MR.
  2. Ran drush updb - this informed me that I needed the Select or other module now, so I have installed that and re-ran drush updb.
  3. I went to my podcast RSS view, and clicked on the "Settings" link for the "Podcast RSS feed" format, and saw the same issue as before 🙁

So, Claude and I spent some alone time together and did the following:

  1. Found an bug and filed an issue and MR with Select or Other module: https://www.drupal.org/project/select_or_other/issues/3590765
  2. Updated most of the form elements in podcast/src/Plugin/views/style/Rss.php to fallback gracefully when there are missing array keys.
  3. Similar, but fewer updates in podcast.module

MR updated.

-mike

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Fixed

Let's get this merged then.
Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.