The readdir(), rewinddir(), and closedir() functions accept null as the value for the $dir_handle, in which case it will used the previously opened directory stream opened with opendir().
- https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_null_to_...
- https://github.com/php/php-src/commit/dc0962c2439d6140c918f132e2a24129c0...
git grep 'readdir()'
use variable to pass directory handle
- MR
- wait for beta
- review/commit
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !12952
Comments
Comment #3
andypostLooks the only place to fix
Comment #4
penyaskitoThis argument is nullable (and exists) since 8.0.0. So based on https://www.drupal.org/docs/getting-started/system-requirements/php-requ..., I think this is good to merge. Existing test coverage should be enough, as @andypost proved this fails on php5. I don't think we have a way (yet) of proving this passes tho.
I'm assuming we want this backported to 11.2.x.
I checked that we don't need this specific fix for 10.5.x, but didn't check if there are any other readdir(), rewinddir(), and closedir() usages in that branch. I don't even know if supporting 10.5.x means we should ensure it works with php85
Comment #5
phenaproxima+1 RTBC here.
Comment #6
alexpottCommitted and pushed 6c0071f6725 to 11.x and de03f6e2853 to 11.2.x. Thanks!
Comment #10
andypostthank you!