Problem/Motivation

$this->connection call should not be directly called outside of Api service.

Proposed resolution

Remove all direct calls with correct ones, like waitForTask with waitForUpdate, to not directly access $this->connection outside of the Api service.

Issue fork search_api_meilisearch-3540465

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

deaom created an issue. See original summary.

deaom opened merge request !65

deaom’s picture

deaom commented
Status: Active » Needs review
Related issues: +#3540463: Add timeout to waitForTask()

When adding the timeout to waitForUpdate in #3540463: Add timeout to waitForTask() discovered that the waitForTask is sometimes directly called, which should not happen. That also means the timeout set was not always applied. Checked if there are any other instance where $this->connection is directly called, found some in tests but other than that the only issue was with waitForTask. Again, test are expected to fail as the #3540463: Add timeout to waitForTask() first needs to be merged to add the timeout.
Setting to needs review to not cause confusion.

bcizej made their first commit to this issue’s fork.

  • bcizej committed 89bb630f on 3.x authored by deaom 
    Issue #3540465 by deaom: Do not expose $this->connection()
bcizej’s picture

bcizej commented
Status: Needs review » Fixed

Rebased and merged, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.