Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_share-3540410

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

joachim opened merge request !120

joachim’s picture

joachim commented

RevisionTest and EmbeddedEntityTest BOTH pass for me locally with Drupal core 10.5, which is what the CI has too.

No idea why they would fail on gitlab.

Generally though, these tests are too complex and have too many moving parts. E.g. tests for pulling content and different processors should be not be using basic_auth -- it's adding an extra unrelated thing that can go wrong.

joachim’s picture

joachim commented
Title: enable gitlab CI » tests are failing on gitlab CI on 8.x-3.x
Category: Task » Bug report
Priority: Normal » Critical

I'm giving up on this.

The tests pass locally in DDEV, and also using the ddev-for-drupal-contrib DDEV setup.

I can get them to reproduce with gitlab-ci-local (see https://project.pages.drupalcode.org/gitlab_templates/info/test-locally/...) but so far, the limited debugging capabilities of that setup are not showing me anything useful.

I'm going to convert this to a bug report, but I don't have any more time I can put into this.

Which also means that I think it's time to close the 8.x-3.x branch, as without CI it's much harder to commit MRs.

cmlara’s picture

cmlara
he/him
commented

Coming from Slack: This is a 60 second review (more time spent writing this than actually looking at issues)
based on your recent commits, Slack comments, and the stack trace present in your logs.

https://git.drupalcode.org/issue/entity_share-3540410/-/blob/8.x-3.x/mod...

Without 100% validating the API I suspect (95% confidence) that your telling Guzzle to ignore your base_uri by having a leading / on the path (base paths are generally only for relative links and a leading '/' is not relative).

Explains the login failure and inability to download files (if I'm reading the rest of the test logs correctly).

  • joachim committed 1b8d04de on 8.x-3.x 
    Issue #3540410: Enabled testing on Gitlab CI (and fixed tests).

joachim credited fjgarlin.

joachim’s picture

joachim commented
Status: Active » Fixed
joachim’s picture

joachim commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.