Problem/Motivation
In #3534092: Deprecate file_system_settings_submit() and move to \Drupal\file\Hook\FileHooks we moved file_system_settings_submit() to \Drupal\file\Hook\FileHooks::settingsSubmit() and deprecated. However, in #3537261: Move file form hooks to FileFormHooks class we moved it to \Drupal\file\Hook\FileFormHooks::settingsSubmit() but didn't update file_system_settings_submit() to point to the new location.
Calling file_system_settings_submit() will now throw a method not found exception.
Steps to reproduce
Proposed resolution
Update file_system_settings_submit() to call \Drupal\file\Hook\FileFormHooks::settingsSubmit()
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3540101
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3540101-deprecated-filesystemsettingssubmit-calls
changes, plain diff MR !12929
Comments
Comment #3
kim.pepperComment #4
kim.pepperComment #5
acbramley commentedWoops :D confirmed that this is valid - another reason to try and get our phpstan levels higher.
Comment #6
catchCommitted/pushed to 11.x, thanks!
Comment #9
kim.pepperWould be good to have an alternative to \Drupal::service() that takes a class name so we can do this:
...and have phpstan do the validation.