Problem/Motivation

In #3534092: Deprecate file_system_settings_submit() and move to \Drupal\file\Hook\FileHooks we moved file_system_settings_submit() to \Drupal\file\Hook\FileHooks::settingsSubmit() and deprecated. However, in #3537261: Move file form hooks to FileFormHooks class we moved it to \Drupal\file\Hook\FileFormHooks::settingsSubmit() but didn't update file_system_settings_submit() to point to the new location.

Calling file_system_settings_submit() will now throw a method not found exception.

Steps to reproduce

Proposed resolution

Update file_system_settings_submit() to call \Drupal\file\Hook\FileFormHooks::settingsSubmit()

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3540101

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

Status: Active » Needs review
kim.pepper’s picture

Issue summary: View changes
acbramley’s picture

Status: Needs review » Reviewed & tested by the community

Woops :D confirmed that this is valid - another reason to try and get our phpstan levels higher.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

  • catch committed 15860ab3 on 11.x
    Issue #3540101 by kim.pepper: Deprecated file_system_settings_submit()...

kim.pepper’s picture

Would be good to have an alternative to \Drupal::service() that takes a class name so we can do this:

/**
 * @template T of object
 * @param class-string<T> $className
 * @return T
 */
function createInstance(string $className): object {}

...and have phpstan do the validation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.