Problem/Motivation
hook_hook_info still needs to execute.
Steps to reproduce
Proposed resolution
Remaining tasks
We should probably add a test for this and the views one so they don't get set inadvertently, we can add it to module_test
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | hookFinder.txt | 29.61 KB | nicxvan |
Issue fork drupal-3540033
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
nicxvan commentedComment #4
karingThank you
Linking it back to the issue we identified / reported here -> https://www.drupal.org/project/webform/issues/3539377
Comment #5
nicxvan commentedCritical because this prevents saving webform fields.
Comment #6
nicxvan commentedI pulled the views test since it is technically out of scope and views isn't affected.
I think this is ready, I'll open a followup to confirm there is test coverage for views.
Comment #7
nicxvan commentedComment #8
nicxvan commentedComment #9
quietone commentedComment #10
nicxvan commentedComment #11
nicxvan commentedI have attached a file of all functions remaining.
I only see system_hook_info and views_hook_info.
There are a lot of template_preprocess, but those are ok.
Comment #12
nicxvan commentedComment #13
nicxvan commentedComment #14
nicxvan commentedComment #16
nicxvan commentedThis is ready for review again.
Comment #17
berdirI think this looks good now, lets get this in as tokens on HEAD are very broken right now (in contrib)
Removing the release notes tag, because this was a misunderstanding on which branch this was, we don't need a note to say something was fixed that was never in a release.
I did update two existing change records to mention this instead, I also restructured https://www.drupal.org/node/3490771 in general to push down the attribute stuff and by default use the new parameters and attribute names because that change record is much more useful than the other one.
Comment #20
catchCommitted/pushed to 11.x, thanks!