Problem/Motivation

hook_hook_info still needs to execute.

Steps to reproduce

Proposed resolution

Remaining tasks

We should probably add a test for this and the views one so they don't get set inadvertently, we can add it to module_test

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 hookFinder.txt29.61 KBnicxvan

Issue fork drupal-3540033

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan opened merge request !12926

nicxvan’s picture

nicxvan commented
Issue summary: View changes
karing’s picture

karing
Location 🇨🇦
commented

Thank you

Linking it back to the issue we identified / reported here -> https://www.drupal.org/project/webform/issues/3539377

nicxvan’s picture

nicxvan commented
Priority: Normal » Critical
Status: Active » Needs review

Critical because this prevents saving webform fields.

nicxvan’s picture

nicxvan commented

I pulled the views test since it is technically out of scope and views isn't affected.

I think this is ready, I'll open a followup to confirm there is test coverage for views.

nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue tags: +Needs release note
nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
StatusFileSize
new hookFinder.txt29.61 KB

I have attached a file of all functions remaining.

I only see system_hook_info and views_hook_info.

There are a lot of template_preprocess, but those are ok.

nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Title: Remove skip procedural for modules implementing hook_hook_info » Do not skip scanning for procedural hooks in the system module

nicxvan changed the visibility of the branch 11.x to hidden.

nicxvan’s picture

nicxvan commented

This is ready for review again.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs release note

I think this looks good now, lets get this in as tokens on HEAD are very broken right now (in contrib)

Removing the release notes tag, because this was a misunderstanding on which branch this was, we don't need a note to say something was fixed that was never in a release.

I did update two existing change records to mention this instead, I also restructured https://www.drupal.org/node/3490771 in general to push down the attribute stuff and by default use the new parameters and attribute names because that change record is much more useful than the other one.

catch closed merge request !12926

  • catch committed b7c20c68 on 11.x 
    Issue #3540033 by nicxvan, karing, berdir: Do not skip scanning for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.