We no longer need the extra bit for CSSOPtimizerUnitTest
core/tests/Drupal/Tests/Core/Asset/CssOptimizerUnitTest.php
since #3034072: Move file uri/scheme functions from file.inc and FileSystem to StreamWrapperManager
Delete this at the bottom:
/**
* CssCollectionRenderer uses file_uri_scheme() which need to be mocked.
*/
namespace Drupal\Core\Asset;
if (!function_exists('Drupal\Core\Asset\file_uri_scheme')) {
function file_uri_scheme($uri) {
return FALSE;
}
}
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !12930
Comments
Comment #2
nicxvan commentedComment #5
tanushree gupta commentedI've removed the provided lines
Kindly review
Comment #6
berdirNeeds a phpstan baseline update.
Comment #7
tanushree gupta commentedWe've removed the `file_uri_scheme()` mock from the test as requested. After doing that, the test is now throwing a 500 error — likely because the function isn't available in the test context anymore.
We've updated the PHPStan baseline to reflect the current state.
Just wanted to check how you'd prefer we handle this:
* Should we include the required `file.inc` file manually in the test (using something like `require_once`)?
* Or would it make more sense to convert this into a `KernelTestBase` or another test type where the function is already available?
* Or is it okay to leave things as they are now with the updated baseline?
Comment #8
berdirfile_uri_scheme() was removed a long time ago. the test fail is unrelated, those tests just sometimes randomly fail. If it doesn't look related to your changes, you can trigger a retest. I did that now.
Comment #9
tanushree gupta commentedThank you!!
Comment #10
smustgrave commentedSeems straight forward enough.
Comment #12
catchCommitted/pushed to 11.x, thanks!
Comment #14
catchComment #15
catch