Problem/Motivation

The current implementation of the Acquia CMS Video module includes a dependency on the Acquia CMS Common module. So, installing Acquia CMS Video module installs Acquia CMS Common module, which in turn brings in several additional modules that are not necessary for Acquia CMS Video to function. To streamline dependencies, we should remove the reliance on Acquia CMS Common and instead declare only the modules directly required by Acquia CMS Video (e.g., Field Group).

Proposed resolution

  1. Review and limit module dependencies so that only modules essential to Acquia CMS Video remain enabled.
  2. Update the GitLab CI template and use CI template provided by Drupal Core, replacing the current ORCA setup, and remove any files specific to ORCA.
  3. Add / Update code in Acquia CMS Video module for module to function as expected.
  4. Refactor and update PHPUnit tests to ensure they are passing.
  5. Ensure all CI pipelines complete successfully, including those in the "allowed failures" category.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

vishalkhode created an issue. See original summary.

vishalkhode’s picture

Status: Active » Needs review
ankitv18’s picture

Left a comment, please check.
Keeping this in review for other inputs

ankitv18’s picture

Ignore above feedback as Backward Compatibility is handled in the .module hooks

  • vishalkhode committed 36c2de47 on 2.x
    Issue #3539132 by vishalkhode: Decouple Acquia CMS Video from Common...
vishalkhode’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.