In src/Plugin/Parameter/Http.php there are question marks missing for PHP 8.4 compatibility:

public function getData($url, ?BubbleableMetadata $bubbleable_metadata = NULL, $throw_exception = FALSE, $use_cache = TRUE, bool &$faulty = FALSE) {

  protected function writeCache($use_cache, $uri, $body, array &$data, BubbleableMetadata $bubbleable_metadata, ?ResponseInterface $response = NULL) {

  protected function fallbackOnFailure($use_cache, $uri, &$body, &$data, ?BubbleableMetadata $bubbleable_metadata, ?ResponseInterface $response = NULL) {

Issue fork parameters-3539076

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rgpublic created an issue. See original summary.

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

dhruv.mittal opened merge request !10

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Active » Needs review

Please review

  • mxh committed 2c571ce6 on 1.0.x 
    Issue #3539076: PHP 8.4 compatibility
mxh’s picture

mxh commented
Status: Needs review » Fixed
rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented

Umm, I might be wrong but I have the feeling sth. went wrong here. The changes committed were probably also necessary, but the changes I suggested above are still required. Version 1.6.2 is still not compatible with PHP 8.4.

  • mxh committed 21bddfad on 1.0.x 
    Issue #3539076: PHP 8.4 compatibility
mxh’s picture

mxh commented
Status: Fixed » Active

:(

mxh’s picture

mxh commented
Version: 1.6.0 » 1.0.x-dev
Status: Active » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.