Problem/Motivation

The module clear requires View Data Export (VDE) in its composer.json but the same dependency should also be stated in the .info.yml otherwise site builders are not made aware that VDE also needs to be enabled. This will cause trouble when trying to access any EXPORT features.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sirclickalot created an issue. See original summary.

jparmar’s picture

Yes aggree to declare Drupal-level (runtime) dependency — so that Drupal knows to enable that dependency module when enabling your module.
Added patch for it.

jparmar’s picture

Status: Active » Needs review
bhogue’s picture

I can confirm that after applying the patch, the dependency is noted on the "extend" page and when installing the module, the modules it depends upon are also installed.

Screenshot of the Node Link Report module on the Extend page declaring the dependency

Screenshot of Node Link Report's dependencies being installed

swirt made their first commit to this issue’s fork.

swirt’s picture

Thanks sirclickalot, jparmar, and bhogue for all your work on this and contributing. Unfortunately it took the problem in the wrong direction. node_link_report does not use views_data_export. It was mistakenly added to the composer.json as a result of copy and paste.
I created an MR to remove it and will merge that shortly.

The nice thing about MR rather than patches is that they generate tugboat preview instances so it makes it really quick to review things on vanilla installs.

  • swirt committed 2797860e on 8.x-1.x
    #3538721 Remove incorrect dependency on views_data_export
swirt’s picture

Status: Needs review » Fixed
swirt’s picture

Title: Requires Views Data Export but info.yml does not confirm the fact » Remove views_data_export composer dependency
swirt’s picture

Status: Fixed » Closed (fixed)

Released as 8.x-1.21