Problem/Motivation

Add tests to check, that words partially containing an entity name won't get glossified.

See #3538523: Add option for partial word glossification ("Abc Xyz+" does not get replaced).

Steps to reproduce

Proposed resolution

Add tests to check, that words partially containing an entity name won't get glossified.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork glossify-3538691

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil’s picture

grevil commented
Title: Add tests to check, that words partially containing an entity name won't get glossified » Add tests to check, that words partially containing an entity name won't get glossified and fix deprecations

grevil opened merge request !54

grevil’s picture

grevil commented
Status: Active » Needs review

All done, please review!

grevil’s picture

grevil commented

Note, that "@covers ::parseTooltipMatch" was never meant for methods:

Attribute "PHPUnit\Framework\Attributes\CoversMethod" cannot target method (allowed targets: class)

Therefore I removed it. We could add it to the class, but CoversClass should be enough IMO.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Nice, thank you @grevil!! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Reviewed & tested by the community » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

All green!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

  • anybody committed 949a45c7 on 3.x authored by grevil 
    Issue #3538691 by grevil, anybody: Add tests to check, that words...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.