Problem/Motivation

Do the deprecation once all 3 other child issues are committed

Proposed resolution

Deprecate constants.

API changes

DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED are deprecated

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3538662

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !12867

acbramley’s picture

acbramley commented
Title: [PP-3] Deprecate DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED » [PP-1] Deprecate DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED
mstrelan’s picture

mstrelan commented

I wonder if the change record should provide more guidance on what to do if you're using these constants outside of core, such as implement your own enum or provide your own constants.

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Deprecate DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED » Deprecate DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED
Status: Postponed » Needs work

nicxvan made their first commit to this issue’s fork.

nicxvan’s picture

nicxvan commented

I updated the CR to be more clear based on 4.

I also rebased using the ui.

I'll finish a review if tests pass.

nicxvan changed the visibility of the branch 11.x to hidden.

nicxvan’s picture

nicxvan commented
Status: Needs work » Reviewed & tested by the community

Deprecations look right and link to the cr.

The cr had been updated.

There are no other references to these constants in core.

I think this is ready.

  • catch committed 4e3f8c90 on 11.x 
    Issue #3538662 by acbramley, nicxvan, mstrelan: Deprecate...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !12867

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.