Problem/Motivation

Part of #2851705: [meta] Deprecate DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED - we want to deprecate DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED. Doing this in a single issue is too hard to review and we want to change the API as we go.

This ticket is for the Link module.

Proposed resolution

- Add LinkTitleVisibility enum
- Replace usages of constants with new enum

API changes

None

Release notes snippet

N/A

Issue fork drupal-3538661

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !12865

acbramley’s picture

acbramley commented
Status: Active » Postponed

Postponing this on #3538277: Add NodePreview enum and replace usage of DRUPAL_DISABLED, DRUPAL_OPTIONAL and DRUPAL_REQUIRED for enum logic reuse.

acbramley’s picture

acbramley commented
Status: Postponed » Needs review
mstrelan’s picture

mstrelan commented

Only one thing I'm not sure about in LinkFieldTest, not changing status here.

mstrelan’s picture

mstrelan commented
Status: Needs review » Reviewed & tested by the community
dww’s picture

dww
we/he/they
commented

Just did a close review on the MR changes. Agreed this is RTBC. I resolved a couple of the open threads. Left a micro-nit on 1 open thread, but not worth changing the status over it.

However, do we need a CR here to introduce the new enum?

Thanks,
-Derek

dww’s picture

dww
we/he/they
commented

Saving credit for code and reviews.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs another rebase.

acbramley’s picture

acbramley commented
Status: Needs work » Reviewed & tested by the community

Rebased cleanly via the UI for me

  • catch committed b6ecca3c on 11.x 
    Issue #3538661 by acbramley, mstrelan, dww: Add LinkTitleVisibility enum...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !12865

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.