Problem/Motivation

Part of #3504381: [meta] Convert Template Preprocess hooks to OOP equivalent

Scope is to convert all remaining template preprocess functions in include files that aren't already in a dedicated issue (such as views, system, image, see meta issue)

Steps to reproduce

Proposed resolution

* Move all template_preprocess functions in update module to $ModuleThemeHooks, including hook_theme itself
* Deprecate the old functions and move them to .module, so that the file definitions can be removed
* Update all references, including direct calls in tests and @see/@covers in tests and templates.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3538089

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Just three modules left, with 5 template preprocess functions in total. One less than I expected, also because block_content is being taken care of in a separate issue and fully deprecated.

berdir opened merge request !12846

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good conversion

nicxvan’s picture

nicxvan commented

+1

Did all of my usual checks except the zebra check.

No double _
All deprecations are the right version and the same 11.3 and removed in 12.

All functions are __FUNCTION__ and files are __FILE__

initial preprocess align and so do the deprecated calls.

Comments were updated correctly.

I'll run the zebra check if i get a chance.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • catch committed c2382a5c on 11.x 
    Issue #3538089 by berdir, nicxvan: Convert remaining template_preprocess...

catch closed merge request !12846

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.