BareHtmlPageRenderer calls renderRoot and can lead to endless scanning loop [#3537922]

Problem/Motivation

BareHtmlPageRenderer calls renderRoot and can lead to the scan going endlessly. Instead we need to render the node in isolation.

Steps to reproduce

Proposed resolution

    $html_build = [
      '#type' => 'html',
      '#attributes' => [],
      'page' => [
          '#type' => 'page',
          '#theme' => 'page',
          '#title' => '',
          'content' => $build,
        ],
    ];
    $html = $renderer->renderInIsolation($html_build);

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork acquia_optimize-3537922

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3537922-barehtmlpagerenderer-calls-renderroot

changes, plain diff MR !21

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

24 July 2025 at 17:48

mglaman created an issue. See original summary.

Comment #2

25 July 2025 at 04:10

ankitv18 opened merge request !21

Comment #3

25 July 2025 at 04:11

ankitv18 made their first commit to this issue’s fork.

Comment #4

deepakkm commented 25 July 2025 at 06:40

Also keeping everyone in line that this should also be tested out with any module which runs ajax where optimize is running.

Comment #5

25 July 2025 at 07:31

ankitv18 changed the visibility of the branch 3537922-barehtmlpagerenderer-calls-renderroot to hidden.

Comment #6

ankitv18 commented 25 July 2025 at 08:56

Proposed solution isn't fixing the actual cause, also Ajax call still conflicted with a autosave_form.
And please note if I replace with the proposed solution then META description, sub-headings and Title are missing from SEO checks.

The bare_html_page_renderer service renders a complete HTML page without the normal Drupal page structure (no admin toolbar, no blocks, no theme regions - just the raw content). elements, meta tags, etc. automatically included

Whereas renderInIsolation renders just the content without full page structure and other SEO required elements will be missed like META tags, Title and other HEAD elements.