Closed (fixed)
Project:
JSON:API Query Builder
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jul 2025 at 08:16 UTC
Updated:
23 Sep 2025 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vipin.mittal18Comment #4
vipin.mittal18Comment #5
ankitv18 commentedI created a symlink to version 5 of gin at my local to validate it using MR!5 of issue https://www.drupal.org/project/jsonapi_query_builder/issues/3529219.
Adding screenshot for your reference


Comment #6
ankitv18 commentedComment #7
ankitv18 commentedComment #8
balsamaThanks for this. Not necessarily related to this MR, but we should look into the following while we're working on this:
Comment #9
vipin.mittal18This module also works with another theme without causing UI breaks. Is there any reason to place the Gin theme condition?
Comment #15
traviscarden commentedI propose we remove the dependency altogether. I've successfully tested with with Gin 4.x and 5.x, Claro, and even Olivero, and it works fine in all of them. (It's squished in Olivero, of course, but it still works; and if you're using Olivero for your admin you're probably already collecting rent money from the voices in your head.)
In fact, it works so well in Claro, most people would probably be hard-pressed to tell the difference. Since that's the case with the default admin theme in Core, I don't think it's even worth mentioning Gin, much less putting it in
hook_requirements().Assuming we all agree on that, we just need to make one other decision: do we completely remove the Gin requirement from
composer.jsonor not? It would technically be a backward compatibility break, because someone could have the theme installed solely as a transitive Composer dependency (i.e., because they'verequired JSON:API Query Builder and it in turnrequires Gin). If we just remove it from our requirements, it would suddenly disappear from that person's codebase when they update. But I don't know if we have any sort of BC commitment. So...I've removed the
hook_requirements()implementation in both MRs, so unless I'm missing something, I think we're ready to just choose between them.Technical notes:
js/react-app/src/gin.cssand corresponding HTML classes in the frontend code that seem to imply Gin support, but as far as I can tell, they're not actually specific to Gin (they create no implicit dependency), and they didn't cause any problems in any of the other themes I tested. There's nothing about them in the documentation or the commit log. I'm guessing the naming convention is just an artifact of AI oddities. I suggest we just leave them in there until and unless we a more rigorous audit/clean-up in the future.jsonapi_query_builder.installfile in both MRs, because all it had was the hook implementation. That will probably cause a merge conflict with #3529219: Replace JSON:API Schema dependency with Open API JSON:API module, but I think there would've been one either way, and it will be trivial to resolve.Comment #16
balsamaMoved target to 2.x branch
Comment #17
balsamaCommitted https://git.drupalcode.org/project/jsonapi_query_builder/-/merge_requests/9 to the 2.0.x branch here https://git.drupalcode.org/project/jsonapi_query_builder/-/commit/b95755...
Thanks!
Comment #19
balsama