Problem/Motivation

The DrimageStageFileProxySubscriber decorator is missing its service definition, thus it is not invoked.

Steps to reproduce

  • Have Stage File Proxy installed
  • Have an image showing on an entity that is not present locally and should be fetched using Stage File Proxy
  • Put xdebug breakpoints in both StageFileProxySubscriber and DrimageStageFileProxySubscriber, load the entity and notice DrimageStageFileProxySubscriber is never hit

Proposed resolution

Add the service/decorator definition

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release drimage_improved-1.0.9

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3537415 by andreasderijcke: Fixed overlooked and leftover DrimageStageFileProxySubscriber missing service definition after fork

Issue fork drimage_improved-3537415

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andreasderijcke created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Andreas, for reporting

Drupal 11.2 || 10.5 or <=11.1 || <=10.4
Do we need a new branch to manage that?

andreasderijcke opened merge request !19

rajab natshah’s picture

rajab natshah
he/him
commented

I see it now

grep -r "DrimageStageFileProxySubscriber" .
./docroot/modules/contrib/drimage_improved/src/DrimageServiceProvider.php:use Drupal\drimage_improved\EventSubscriber\DrimageStageFileProxySubscriber;
./docroot/modules/contrib/drimage_improved/src/EventSubscriber/DrimageStageFileProxySubscriber.php:class DrimageStageFileProxySubscriber implements EventSubscriberInterface {
./docroot/modules/contrib/drimage_improved/src/EventSubscriber/DrimageStageFileProxySubscriber.php:   * Constructs a new DrimageStageFileProxySubscriber.
andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
commented
Assigned: andreasderijcke » Unassigned
Status: Active » Needs review

I think this is just an overlooked part after forking from drimage, with either part of a solution or leftover from a test.

See the MR for my proposal.

rajab natshah’s picture

rajab natshah
he/him
commented

I agree, it was not changed after forking.
The name of the file DrimageImprovedServiceProvider.php and class name!

Thank you :)

rajab natshah’s picture

rajab natshah
he/him
commented
Title: DrimageStageFileProxySubscriber is missing its service definition » Fix overlooked and leftover DrimageStageFileProxySubscriber missing service definition after fork

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » josebc
Issue summary: View changes
Issue tags: +drimage_improved-1.0.9
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: josebc » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released drimage_improved-1.0.9

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes