Problem/Motivation

Module is not compatible with php 8.4 and throwing warning on drush cr.

Steps to reproduce

Deprecated function: Drupal\samlauth\SamlService::reformatConfig(): Implicitly marking parameter $key_repository as nullable is deprecated, the explicit nullable type must be used instead in include() (line 576 of /var/www/html/vendor/composer/ClassLoader.php)

Deprecated function: Drupal\samlauth\SamlService::doLogin(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in include() (line 576 of /var/www/html/vendor/composer/ClassLoader.php)

Proposed resolution

Fix php code and make it compatible

CommentFileSizeAuthor
#2 3537395-samauth-deprecation.patch1.08 KBnehajyoti

Issue fork samlauth-3537395

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nehajyoti created an issue. See original summary.

nehajyoti’s picture

nehajyoti commented
StatusFileSize
new 3537395-samauth-deprecation.patch1.08 KB

Unable to create MR https://git.drupalcode.org/issue/samlauth-3537395/-/merge_requests/new?m...

Hence adding patch

magdalenaa67’s picture

magdalenaa67 commented

#2 patch seems to have worked for my site. It is only in INT server, but I no longer see the deprecation issues. Thank you! This is on a Drupal 11 site with php 8.4.

roderik opened merge request !42

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.