Problem/Motivation
Calling $migration->getMigrationDependencies() from a field plugin results in an infinite loop. This is because that method calls ::expandPluginIds, which in turn calls ::getDefinitions which in turn calls the node deriver, which in turn calls ::getDerivativeDefinitions calls the field plugin manager, which loops ad nauseam.
Steps to reproduce
See problem statement above.
Proposed resolution
Reverse course on always expanding plugin IDs. If someone needs it, they should have to consciously call for it.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Comments
Comment #2
heddn#3494209: Drupal 7 to Drupal 11 migration runs forever complains about this on the contrib project. Given it is breaking contrib, I'm moving this to a major.
Comment #3
heddnFor now, I'm going to implement https://git.drupalcode.org/project/paragraphs/-/merge_requests/115/diffs... in the contrib module that this effects. I'm not sure another rewrite off all this when field migrations are about to go away is really desired.